Skip to content
This repository has been archived by the owner on Mar 19, 2024. It is now read-only.

Grid should not be focusable #28

Open
juanca opened this issue Jul 16, 2018 · 2 comments
Open

Grid should not be focusable #28

juanca opened this issue Jul 16, 2018 · 2 comments
Labels
bug Something isn't working

Comments

@juanca
Copy link
Owner

juanca commented Jul 16, 2018

0976d4a

@juanca
Copy link
Owner Author

juanca commented Jul 16, 2018

A little more information on this topic:

There is a ES lint rule that dictates any interactive element should also be focusable.

This makes sense. However, it defines an interactive element as any element with an event handler on click or keyboard events.

In the case for the Grid component, it is only capturing event which bubbled from some grid cell. The Grid component itself is not interactive but it is macro managing the interactions for its grid cells.

I am reading more on this and will see if there is an official work around.

@juanca
Copy link
Owner Author

juanca commented Jul 16, 2018

It seems like the official work around is to mark the HTML element as "presentational" through a presentation role.

This doesn't work with a grid since it has the "grid" role already.

I might follow up as an issue? Or leave the lint rule disabled for that particular element.

@juanca juanca added the bug Something isn't working label Jun 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant