Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App Crash tvOS 16 #54

Open
A32rj3gebebr opened this issue Sep 18, 2022 · 10 comments · May be fixed by #58
Open

App Crash tvOS 16 #54

A32rj3gebebr opened this issue Sep 18, 2022 · 10 comments · May be fixed by #58

Comments

@A32rj3gebebr
Copy link

The app crashes on an Apple TV 4K (1st gen) since the update to tvOS 16 as soon as you want to play a video. Before that it worked without problems.

@AshWhitear
Copy link

Here's some extra info:

*** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '-[WebCoreNSURLSessionTaskTransactionMetrics _privacyStance]: unrecognized selector sent to instance 0x283562a30'

@red-lonely-neuron
Copy link

red-lonely-neuron commented Jan 7, 2023

Hi. I have also got that exception attempting to play a video, no matter the site. I have attempted to debug it but Xcode drops me in some assembler code. Nothing useful.
For the build, I have used macOS 13.1, Xcode 14.2. I have set multiple tvOS versions: 11, ..., 16.
Is it related to some entitlements the application might not have?

@AshWhitear
Copy link

AshWhitear commented Jan 7, 2023

Since tvOS 16 there may be a required var that isn’t included in the webkit version we use (microsoft/playwright#10892). We may need to try build an updated webkit package

@staskus
Copy link

staskus commented Jan 18, 2023

I found a workaround by adding a dummy method at runtime. I'm not an expert but it seems to do the job and the crashes no longer happen.

CC: @A32rj3gebebr, @AshWhitear , @red-lonely-neuron if you still interested.

@beckmx
Copy link

beckmx commented Jan 19, 2023

@staskus i just tested and at least on 16.1 didn’t work, it crashed on yt and fb, what tvOS version u have? And generation?
edit: it did work! I didnt checkout your fix branch

@staskus
Copy link

staskus commented Jan 19, 2023

edit: it did work! I didnt checkout your fix branch

Great to know, thanks for confirming! I added the wrong link to my message, which might've created confusion.

@red-lonely-neuron
Copy link

I have also tested the fix and the application didn't crash.

@RHStonks
Copy link

@staskus this fixes the issue. Is it possible for you to fix the full screen issue. I'm unable to fullscreen when watching videos?

@staskus
Copy link

staskus commented Feb 23, 2023

@staskus this fixes the issue. Is it possible for you to fix the full screen issue. I'm unable to fullscreen when watching videos?

@RHStonks thanks for testing!

I investigated full screen before, and it seems to be a separate issue, coming from the fact that tvOS does not officially support the usage of web views. One of my ideas was to extract the video source and feed it to AVPlayer but I haven't had a chance to experiment with that. Maybe there're other ways as well.

@RHStonks
Copy link

@staskus this fixes the issue. Is it possible for you to fix the full screen issue. I'm unable to fullscreen when watching videos?

@RHStonks thanks for testing!

I investigated full screen before, and it seems to be a separate issue, coming from the fact that tvOS does not officially support the usage of web views. One of my ideas was to extract the video source and feed it to AVPlayer but I haven't had a chance to experiment with that. Maybe there're other ways as well.

Thanks for the reply. Glad to have people like you to fix these issues.

Can't wait to see if you can extract the video source and feed it to AVPlayer. Would be a game-changer to be able to watch videos in fullscreen.

I wonder where the original developer has gone. Hasn't been active since the beginning of 2021.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants