Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate ToolTip documentation failed with error: Unsupported ToolTip Control: Repeater #464

Open
buzzwick opened this issue Aug 7, 2024 · 4 comments
Labels
bug Something isn't working needs more info Issue requires more information from poster

Comments

@buzzwick
Copy link

buzzwick commented Aug 7, 2024

AL language extension v14.0.1070882 (pre-release)
NAB AL Tools v1.32.0

First time running the tool on this repository. How do I interpret this message and track down the unsupported control? Does it mean that Repeaters are unsupported, or that some Repeater has a ToolTip control?

@buzzwick buzzwick added the bug Something isn't working label Aug 7, 2024
@jwikman
Copy link
Owner

jwikman commented Aug 9, 2024

Hi @buzzwick,

Yes, it definitely sounds as if there is a ToolTip on a repeater control.
But as this sounds strange, since AL does not allow this, I assume that there is some issue with the parsing (NAB AL Tools does its own code parsing, for different reasons).

One known limitation of NAB AL Tools is that we do not support block comments (with /* and */), which can end up with really strange behavior. Do you know if that is being used in that project?

Otherwise, I think we need a repro to be able to fix this. Are you able to hunt down the file that is causing this?
This can be achieved by removing objects and running the "Generate Tooltip Documentation" action until the error goes away, and then run the command on the last removed files - and repeat until one single file exists. (One advantage of our own parsing is that the project is not required to compile 🙂)

@jwikman jwikman added the needs more info Issue requires more information from poster label Aug 9, 2024
@buzzwick
Copy link
Author

buzzwick commented Aug 9, 2024

Hello! Thanks for the speedy response! I can do as you suggest with the smaller repo; it is a virtual certainty that there are block comments in there that I can hunt down and delete. A manual inspection did not turn up any instances of Repeaters with Tooltips, which makes sense because I agree they wouldn't be allowed in the first place. I will get rid of the comments first, and then use your method to find offending files.

On a somewhat larger repo, I do not get errors, but I get the "Generating ToolTip Documentation" for 24 hours. The fact that the tool is finding errors in the smaller repo suggests that my install and setup are correct. How would you suggest I find out what is going on with this one that runs forever?

@jwikman
Copy link
Owner

jwikman commented Sep 20, 2024

Hi @buzzwick,
My apologies for the late reply - I totally missed this one...

You might get some clues on what is going on in the Output tab in VSCode, if you select "NAB AL Tools" in the dropdown.

image

I just ran the "NAB: Generate External Documentation" on the BaseApp repo, to see how long it takes. It took about 7 minutes, so having it working for 24h is not expected.

I also ran the "NAB: Generate Tooltip Documentation" function, and it failed in BaseApp - but the error was written in the output tab, so maybe that is your case as well?

ps. Obviously, we're having trouble with namespaces (yes, known limitation) and ControlAddIns (that was new to me, and should be easily fixed).
pps. When I first built the documentation generator, I tested successfully on the BaseApp repo - but BC evolve fast, and sometimes it's hard to keep up with the pace! :)

@jwikman
Copy link
Owner

jwikman commented Sep 22, 2024

Hi again @buzzwick,

I just updated NAB AL Tools, so I get no errors for either external documentation or ToolTip documentation when they are run on the BaseApp project. Hopefully those changes also help you out.

Please install the latest pre-release version (v1.33.409221951) of NAB AL Tools and try again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs more info Issue requires more information from poster
Projects
None yet
Development

No branches or pull requests

2 participants