Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shorten import paths #23

Open
lolmaus opened this issue Jul 3, 2019 · 0 comments
Open

Shorten import paths #23

lolmaus opened this issue Jul 3, 2019 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@lolmaus
Copy link
Contributor

lolmaus commented Jul 3, 2019

Per this suggestion:

This is mostly unrelated to the specific changes here, but just stumbled upon the import path here. Given that the addon is exclusively meant to be used in tests, i.e. there is zero runtime code, I wonder if it wouldn't be nicer to omit the test-support/ part here? Like

import { givenSteps } from 'ember-cli-yadda-opinionated';

Technically this is possible, while still keeping all the imported code in the test-support.js bundle. See https://github.com/kaliber5/ember-window-mock/blob/master/index.js#L6-L23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant