From 4d916c505d932ddd473bccafb84fb97ec97cc69d Mon Sep 17 00:00:00 2001
From: Googler <twerth@google.com>
Date: Tue, 11 Jun 2024 05:22:58 -0700
Subject: [PATCH] Filter out no-op options from options descriptions HTML.

PiperOrigin-RevId: 642233077
Change-Id: I79a5b8e11def42961a7721c45f29682b9f49b57b
---
 .../com/google/devtools/common/options/OptionsParser.java  | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/src/main/java/com/google/devtools/common/options/OptionsParser.java b/src/main/java/com/google/devtools/common/options/OptionsParser.java
index 5dbc3e22202322..4ed594a8ef32df 100644
--- a/src/main/java/com/google/devtools/common/options/OptionsParser.java
+++ b/src/main/java/com/google/devtools/common/options/OptionsParser.java
@@ -536,6 +536,13 @@ public String describeOptionsHtml(Escaper escaper, String productName) {
     for (Map.Entry<OptionDocumentationCategory, List<OptionDefinition>> e :
         optionsByCategory.entrySet()) {
       List<OptionDefinition> categorizedOptionsList = e.getValue();
+      categorizedOptionsList =
+          categorizedOptionsList.stream()
+              .filter(
+                  optionDef ->
+                      Arrays.stream(optionDef.getOptionEffectTags())
+                          .noneMatch(effectTag -> effectTag.equals(OptionEffectTag.NO_OP)))
+              .collect(toImmutableList());
       if (categorizedOptionsList.isEmpty()) {
         continue;
       }