Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misleading recommendation on Scaling Deployments section #1431

Open
0x2b3bfa0 opened this issue Jul 20, 2024 · 2 comments
Open

Misleading recommendation on Scaling Deployments section #1431

0x2b3bfa0 opened this issue Jul 20, 2024 · 2 comments
Labels
bug Something isn't working stale All issues that are marked as stale due to inactivity

Comments

@0x2b3bfa0
Copy link

0x2b3bfa0 commented Jul 20, 2024

Since #265, the documentation provides a note stating that the preStop hook can be used to delay termination:

> 💡 **NOTE:**There are other ways to delay termination, including the [`preStop` Hook](https://kubernetes.io/docs/concepts/containers/container-lifecycle-hooks/#container-hooks)

Unfortunately, containers will still receive SIGKILL after terminationGracePeriodSeconds have elapsed, regardless of the preStop hook, which is just used to delay the initial SIGTERM sent for graceful termination.

With the current wording of this note, I thought for a moment that the preStop hook would take precedence over terminationGracePeriodSeconds and preventing Kubernetes from sending SIGKILL until the hook finished running.

@0x2b3bfa0 0x2b3bfa0 added the bug Something isn't working label Jul 20, 2024
@zroubalik
Copy link
Member

Makes sense, are you willing to contribute an improvement here?

Copy link

stale bot commented Oct 12, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale All issues that are marked as stale due to inactivity label Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working stale All issues that are marked as stale due to inactivity
Projects
None yet
Development

No branches or pull requests

2 participants