Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: Pubsub scaler, document relation between stabilizationWindowSeconds and metrics sample rate #1439

Open
ls-urs-keller opened this issue Jul 30, 2024 · 2 comments
Labels
stale All issues that are marked as stale due to inactivity

Comments

@ls-urs-keller
Copy link

- `mode` - The metric used to scale your workload. It's the `PascalCase` of the official metric name. For example, if you are going to leverage the metric `subscription/pull_request_count`, you will fill the value as `PullRequestCount`. Please refer to https://cloud.google.com/monitoring/api/metrics_gcp#gcp-pubsub. All metrics starting with `subscription/` and `topic/` are supported. (Default: `SubscriptionSize`, aka `NumUndeliveredMessages`)

I'm wondering if you can document a recommendation for the value of stabilizationWindowSeconds given that the underlying pubsub metrics are sampled only every 60s and can take up to 120s to update.

Otherwise, this might unnecessarily scale to the max due to the rate at which the metric updates

@zroubalik
Copy link
Member

@ls-urs-keller makes sense, are you willing to update docs with the details?

Copy link

stale bot commented Oct 12, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale All issues that are marked as stale due to inactivity label Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale All issues that are marked as stale due to inactivity
Projects
None yet
Development

No branches or pull requests

2 participants