Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failure to acquire DATABASE_URL when set after import #179

Open
fritz-clicktripz opened this issue May 23, 2019 · 0 comments
Open

Failure to acquire DATABASE_URL when set after import #179

fritz-clicktripz opened this issue May 23, 2019 · 0 comments

Comments

@fritz-clicktripz
Copy link
Contributor

Records extracts DATABASE_URL from the environment at the module level, at import time.

If the environment changes in between the import, and the instantiation, this change is not reflected.

Proposal to move https://github.com/kennethreitz/records/blob/master/records.py#L13, into the initialization step, conditionally if the value is null at initialization time.
fritz-clicktripz added a commit to fritz-clicktripz/records that referenced this issue May 23, 2019
@fritz-clicktripz
Update records.py
3ae59e7 
Addresses issue kennethreitz#179
@fritz-clicktripz fritz-clicktripz mentioned this issue May 23, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fritz-clicktripz