Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ordering of selected items #100

Open
oriarditi opened this issue Jun 13, 2018 · 8 comments
Open

Ordering of selected items #100

oriarditi opened this issue Jun 13, 2018 · 8 comments

Comments

@oriarditi
Copy link

oriarditi commented Jun 13, 2018

Given any thought of ordering the selected items? Something like hamburgers to reorder selected items
Thanks!

@liorheber
Copy link
Collaborator

Do you mean to have the ability to drag items inside the list or do you mean to have some sort of sort function?

@oriarditi
Copy link
Author

draggable items could be awesome!

@liorheber
Copy link
Collaborator

Sounds interesting.
It means that we will need to store the order somewhere because unfortunately the selectedItems list is recreated every time.
I'll look into it.

@sabativi
Copy link

Hey,

I think this can be done quite easily if the lib can also export defaults components used
Sortable is easy to setup, as just need to:

  • add <div className="sortable-list"> on top of the actual destination list.
  • and use HOC sortable on selectedItemRenderer.

Maybe this is the best way to do it ?

@liorheber
Copy link
Collaborator

Hey @sabativi, thank you for looking into this.

Would you like to give this feature a go and try and issue a PR for it?

@lukaspili
Copy link

It seems #117 was not merged. So it's still not possible to wrap the default components into a sortable HOC, right?

@liorheber
Copy link
Collaborator

Sorry @lukaspili I think he never got to finishing his PR.
I'd be happy to push a change if you'd like to write it.

@lukaspili
Copy link

Thanks for the quick response. At this point I'm just evaluating several options - including multi-select.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants