Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove AlphaSquareEffect from default sketches #25

Open
tlyu opened this issue Sep 24, 2022 · 2 comments
Open

remove AlphaSquareEffect from default sketches #25

tlyu opened this issue Sep 24, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@tlyu
Copy link
Contributor

tlyu commented Sep 24, 2022

Is your feature request related to a problem? Please describe.

The AlphaSquareEffect plugin is not very legible unless translucent keycaps (or no keycaps) are installed. With the usual mostly-black opaque keycaps, it simply looks like random keys being illuminated. I had trouble figuring out what it was trying to do, until I read the description of the plugin. I still had trouble making out the letters until I happened to activate it while all my keycaps were removed (on the Model 01).

Describe the solution you'd like

Remove the AlphaSquareEffect plugin from the default sketches. This frees up some flash memory on AVR devices, and the effect doesn't look very good (and even maybe looks like an error) with the default keycaps installed.

Describe alternatives you've considered

The plugin could remain in the default sketches, taking up flash memory and looking not especially good in the default hardware configuration.

Additional context

N/A

@tlyu tlyu added the enhancement New feature or request label Sep 24, 2022
@obra
Copy link
Member

obra commented Sep 25, 2022 via email

@algernon algernon transferred this issue from keyboardio/Kaleidoscope Sep 25, 2022
@algernon
Copy link
Contributor

There's one potential downside of removing AlphaSquare: if anyone has set up their default LED effect, to something that comes after AlphaSquare, the setting would be off by one after the removal. Colormap is listed after AlphaSquare.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants