Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model01 experimental firmware has NumPad LED effect active #4

Open
fluffy-critter opened this issue Feb 7, 2019 · 5 comments
Open
Labels
bug Something isn't working

Comments

@fluffy-critter
Copy link

When switching to layer 1 while using the experimental firmware, the NumPad LED effect still activates, overriding whatever color scheme is configured in Chrysalis.

@algernon algernon added the bug Something isn't working label Feb 7, 2019
@algernon
Copy link
Contributor

algernon commented Feb 7, 2019

This will be a tough one. In theory, all we need is a way to disable the Numpad plugin. In practice, we need to figure out when to do that.

@fluffy-critter
Copy link
Author

If you’re using chrysalis to edit your color maps do you ever want NumPad enabled? Or another possibility is to put a flag in the EPROM for which layer to use with NumPad and make it possible for it to be whatever you want.

@algernon
Copy link
Contributor

algernon commented Feb 7, 2019

If colormap is used, then numpad should be off, indeed. It's... not easy to do that without introducing a dependency on Numpad to Colormap, which I'd rather avoid. Unless - as you wrote - we write a byte to eeprom and use that to toggle Numpad off.

Alternatively, I could remove the Numpad plugin from the experimental firmware, under the assumption that people using the experimental firmware will want to use Colormap anyway.

(We should probably figure out what the goal of the experimental firmware are, and how much it can deviate from the default, but that's another topic...)

@fluffy-critter
Copy link
Author

Alternatively, I could remove the Numpad plugin from the experimental firmware, under the assumption that people using the experimental firmware will want to use Colormap anyway.

That’s actually what I was getting at, sorry I wasn’t clear. :)

@algernon
Copy link
Contributor

algernon commented Jun 9, 2022

I will not be touching the Model01 firmware, but for the Model 100 firmware, we're in the process of phasing out the NumPad plugin in favour of Colormap + a suitable default palette & map.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants