Skip to content
This repository has been archived by the owner on Nov 24, 2021. It is now read-only.

Should be able to override timeout on signin? #16

Open
jstockwin opened this issue Nov 10, 2016 · 1 comment
Open

Should be able to override timeout on signin? #16

jstockwin opened this issue Nov 10, 2016 · 1 comment

Comments

@jstockwin
Copy link
Contributor

Currently, if you want to extend the default signin wait time you need to do the following:

browser.adminUISignin.signin({ user: 'user@keystonejs.com', password: 'admin', wait: false });
browser.adminUIApp.waitForHomeScreen({ timeout: 60000 });

since by default we only wait for 10000. We could add an optional timeout parameter, so that you can call

browser.adminUISignin.signin({ user: 'user@keystonejs.com', password: 'admin', wait: false, timout: 60000 });

@webteckie What do you think? It seems useful to me, but perhaps we don't want to just add everything we can think of?

@webteckie
Copy link
Contributor

@jstockwin if anything I'd rather have it like this:

browser.adminUISignin.signin({ user: 'user@keystonejs.com', password: 'admin', wait: false });
or
browser.adminUISignin.signin({ user: 'user@keystonejs.com', password: 'admin', wait: 60000 });

In other words, if you don't want the default wait then override it with the same wait parameter. The target function would need to test whether a typeof(wait) === 'boolean' or typeof(wait) === 'number' and do relevant logic.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants