Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'location.origin' is undefined in some IE versions #16

Open
xsc opened this issue Apr 21, 2016 · 0 comments
Open

'location.origin' is undefined in some IE versions #16

xsc opened this issue Apr 21, 2016 · 0 comments

Comments

@xsc
Copy link

xsc commented Apr 21, 2016

In some IE versions, location.origin (or window.location.origin to fully specify it) is undefined [1], resulting in this piece of pushy's code to generate the pattern #"^.*$" - which always matches.

If you're okay with it I'd open a PR implementing the workaround described in [1].

[1] http://tosbourn.com/a-fix-for-window-location-origin-in-internet-explorer/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant