You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Several frameworks's apps are written in a manner that does not reflect the usage suggested in their docs.
For example, the FastAPI documentation suggests using File() to have files extracted from forms and injected: https://fastapi.tiangolo.com/tutorial/request-files/. But in the benchmarks the Request.form is used just like in Starlette. This is obviously going to be faster, but then it's not using any of the features the framework provides on top of Starlette. If that's what users were doing, they'd be using Starlette.
I suggest that the apps get restructured to better reflect the documented usage of each framework. That is much more useful to users (and framework developers) and would help highlight issues like fastapi/fastapi#4187
The text was updated successfully, but these errors were encountered:
adriangb
changed the title
benchmarks do not reflect recommended usage of framewotkd
benchmarks do not reflect recommended usage
Jan 22, 2022
@klen are you open to this? I'm happy to submit PRs, but I don't want it to seem like I am unilaterally trying to hamper specific web frameworks in the benchmarks, so I won't do anything without your explicit approval.
Several frameworks's apps are written in a manner that does not reflect the usage suggested in their docs.
For example, the FastAPI documentation suggests using File() to have files extracted from forms and injected: https://fastapi.tiangolo.com/tutorial/request-files/. But in the benchmarks the Request.form is used just like in Starlette. This is obviously going to be faster, but then it's not using any of the features the framework provides on top of Starlette. If that's what users were doing, they'd be using Starlette.
I suggest that the apps get restructured to better reflect the documented usage of each framework. That is much more useful to users (and framework developers) and would help highlight issues like fastapi/fastapi#4187
The text was updated successfully, but these errors were encountered: