Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AMD/async #102

Open
yassam opened this issue Apr 10, 2012 · 3 comments
Open

AMD/async #102

yassam opened this issue Apr 10, 2012 · 3 comments

Comments

@yassam
Copy link

yassam commented Apr 10, 2012

I'm in the process of updating to dojo 1.7.x and and the latest version of dojango (thanks for working on it by the way). I noticed the amd-loader branch but that it hasn't been touched since December.

Do you plan to allow the use of AMD in the master branch any time soon?

@klipstein
Copy link
Owner

I've started this branch some months ago and recognized that larger parts of dojango would require a change to support that. If you have an idea how to change it I would be happy getting a pull request :)

I'll go through the branch and will document what is required to support AMD.

@yassam
Copy link
Author

yassam commented Jun 5, 2012

Thanks for replying. I was thinking about doing this but I don't know if I'll get time. I'll let you know if I fork and start working on it.

@yassam
Copy link
Author

yassam commented Sep 7, 2012

I created a branch that uses AMD:
https://github.com/yassam/dojango/tree/dojo-2.0

I haven't created a pull request for it because I don't consider it ready, but it does what I need for my current project:

  • Only the template base.html has been tested
  • I haven't updated any of the tests
  • I've done nothing on the builder code
  • I've tried to maintain backward compatibility, but haven't tested it with older versions of dojo (only 1.8)
  • dojoConfig vs. djConfig - this is configurable via a DOJANGO setting and defaults to dojoConfig for dojo version >= 1.6
  • The use of async loading is also configurable

Feel free to merge into your repo if you think it's worth using (I worked off your AMD branch)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants