Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Common enum FrameType for consistent "kernel" type treatment #234

Open
romintomasetti opened this issue Jan 23, 2024 · 0 comments
Open

Common enum FrameType for consistent "kernel" type treatment #234

romintomasetti opened this issue Jan 23, 2024 · 0 comments
Labels
enhancement

Comments

@romintomasetti
Copy link
Contributor

As discussed in #218, it would be better if the frame type is an enum shared by all tools. See common/FrameType.hpp in #218.

I created a new enum FrameType that seeks to homogenize how kernel types are treated amongst tools, and how they are printed. This also deserves another PR if you agree on the principle.

@crtrott @dalg24 @vlkale If you agree on the principle (and the implementation given in #218) I can make a PR for this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vlkale @romintomasetti