Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid depending on Kokkos configuration to enable tools #268

Open
dalg24 opened this issue Aug 7, 2024 · 0 comments
Open

Avoid depending on Kokkos configuration to enable tools #268

dalg24 opened this issue Aug 7, 2024 · 0 comments

Comments

@dalg24
Copy link
Member

dalg24 commented Aug 7, 2024

Prompted by spack/spack#45382 (comment)
We should build the NVTX or ROC-TX just based whether we can detect CUDA or ROCm, respectively. It makes little sense to tie this to the setting of Kokkos.

kokkos-tools/CMakeLists.txt

Lines 190 to 197 in 7604355

# GPU profilers
if(Kokkos_ENABLE_CUDA)
add_subdirectory(profiling/nvtx-connector)
add_subdirectory(profiling/nvtx-focused-connector)
endif()
if(Kokkos_ENABLE_HIP)
add_subdirectory(profiling/roctx-connector)
endif()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant