-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Boolean arguments and add replace them by optional numerical values if possible #29
Comments
Seems that optional argument |
Dear @pablo-angulo,
Thank you for pointing this out. I am aware of this little inconvenience. This simple interface originated from a small project some years ago when there was no convenient interface to the C-library that does the actual work out there. This code solved my problem and in the hope that it would be useful to other people I shared it with the community. My time does not permit working on Julia code since my main projects are of totally different nature. If you think this issue deserves a change you are welcome to improve the code, document it so every potential user will understand how to use it and submit a merge request. This is often the way how small open-source projects work. Best, |
Fair enough. I just started with julia, but the task does not seem hard. Thanks for sharing and will give a shot |
I just started. I'm not using visual studio but plain julia packages: https://pkgdocs.julialang.org/v1/creating-packages/ I hope I don't mess with your config. Before I continue, let me show you a little bit of the work, and please do tell me if it is ok: This is what I did intentionally: And this happened automatically: |
There seems to be no argument for setting
area_max
, just a bool for user input, which is totally awkward. Could you replace user input by a regular argument that we can set from within the code?The text was updated successfully, but these errors were encountered: