Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add transparent strip to avoid hoist edge being hidden within flagpole #65

Open
hamishlawson opened this issue Aug 21, 2022 · 3 comments

Comments

@hamishlawson
Copy link

hamishlawson commented Aug 21, 2022

I've noticed that the flag gets slightly truncated at the hoist, presumably because the flag is treated as being affixed directly to the axis of the flagpole and so some of it is effectively hidden within the flagpole; this is more noticeable with some flag designs. To compensate for this I suggest that FlagWaver adds a transparent strip or a white strip or both to the hoist edge of the flag image. In addition to solving the issue of part of the flag being lost, an added transparent strip would more realistically simulate the appearance of a flag hoisted by ropes, while an added white strip would simulate hoist tape.

Mockups:

@krikienoid
Copy link
Owner

This does look nice. I'm not sure if it's feasible to modify user defined images like that but definitely worth looking into.

@hamishlawson
Copy link
Author

I think an approach might be to create respectively transparent and white images of the appropriate size and combine these with the user's image to give a new image to be used for the flag. This Stack Overflow question discusses combining images in JavaScript.

@krikienoid
Copy link
Owner

The top comment is using a canvas based solution, which is what I had in mind anyway, neat.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants