We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Why CubeOptions need validation? Before running KubeCube, we are supposed to doing options validate, quick exit if validate failed.
Start = func(c *cli.Context) error { if errs := flags.CubeOpts.Validate(); len(errs) > 0 { return utilerrors.NewAggregate(errs) } run(flags.CubeOpts, signals.SetupSignalHandler()) return nil }
How to do it? We had validate method but in fact doing nothing in each validate func, we need complete it.
// Validate verify options for every component // todo(weilaaa): complete it func (s *CubeOptions) Validate() []error { var errs []error errs = append(errs, s.APIServerOpts.Validate()...) errs = append(errs, s.ClientMgrOpts.Validate()...) errs = append(errs, s.CtrlMgrOpts.Validate()...) return errs }
func (c *Config) Validate() []error { return nil }
The text was updated successfully, but these errors were encountered:
zhujf1989
weilaaa
No branches or pull requests
Why CubeOptions need validation?
Before running KubeCube, we are supposed to doing options validate, quick exit if validate failed.
How to do it?
We had validate method but in fact doing nothing in each validate func, we need complete it.
The text was updated successfully, but these errors were encountered: