Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

❓ How to choose default target network for mappings #821

Closed
yaacov opened this issue Jan 9, 2024 · 7 comments
Closed

❓ How to choose default target network for mappings #821

yaacov opened this issue Jan 9, 2024 · 7 comments
Assignees
Labels
enhancement Categorizes issue or PR as related to a new feature. mappings
Milestone

Comments

@yaacov
Copy link
Member

yaacov commented Jan 9, 2024

Issue:
when creating a new network mapping we default the target network to pod network.

It may be nicer to have some better heuristic to guess a NAD that is preferred for virtualization so the user will not need to manually change to pod network to the preferred one.

@yaacov yaacov added the staff-eng-approved Indicates a release branch PR has been approved by a staff engineer (formerly group/pillar lead). label Jan 9, 2024
@yaacov yaacov added this to the 2.6.0 milestone Jan 9, 2024
@yaacov
Copy link
Member Author

yaacov commented Jan 9, 2024

cc:// @ahadas @liranr23 @rszwajko

@yaacov
Copy link
Member Author

yaacov commented Jan 17, 2024

Update:

Corrent dev is done with the assumption of using "Pod netwok"
Ref:
#801 (comment)

cc:// @ahadas

@yaacov yaacov changed the title Choose a "preferred NAD" to default network mappings. 🤷 Choose a "preferred NAD" to default network mappings. Jan 17, 2024
@yaacov yaacov changed the title 🤷 Choose a "preferred NAD" to default network mappings. 🐾 Choose a "preferred NAD" to default network mappings. Jan 17, 2024
@yaacov yaacov changed the title 🐾 Choose a "preferred NAD" to default network mappings. 🐾 ❓ Choose a "preferred NAD" to default network mappings. Jan 17, 2024
@yaacov yaacov added enhancement Categorizes issue or PR as related to a new feature. mappings and removed staff-eng-approved Indicates a release branch PR has been approved by a staff engineer (formerly group/pillar lead). labels Jan 17, 2024
@liranr23
Copy link
Member

i don't see a good way to tell: this is going to be the network we are going to use for our virtualization. i think making wrong network is dangerous. therefore, i do think "Pod network" or any other network that set as a default (like storage, if there is an annotation for it).

@yaacov yaacov changed the title 🐾 ❓ Choose a "preferred NAD" to default network mappings. ❓ How to choose default target network for mappings Jan 22, 2024
@yaacov yaacov modified the milestones: 2.6.0, next Jan 31, 2024
@yaacov
Copy link
Member Author

yaacov commented Jan 31, 2024

move to next, currently we use pod network, we may change that based on user feedback

@ahadas
Copy link
Member

ahadas commented Feb 1, 2024

move to next, currently we use pod network, we may change that based on user feedback

I think we can already say that we use the pod network as a temporary solution, which may be alright for VMs with a single network. Imagine you have a VM with multiple networks - it's not that great to map all networks to the pod network.. as a user I would expect to be told that I should change the mappings if I don't expect all the interfaces to be on the same network on the destination (e.g., "this VM was configured with multiple networks and would have a single network on the destination". btw, are we going to show a message to the user about this implicit networks mapping?)

maybe we tackle this from an incorrect angle - the idea is to simplify the creation of the plan, assuming that selecting existing mappings, and then obviously creating new mappings, makes the process more complex than it should, right? in that case, maybe we should rather have the notion of "default" mappings, mappings that are set for source and destination providers and are selected by default when creating a plan with these providers?

@yaacov
Copy link
Member Author

yaacov commented Feb 1, 2024

maybe we should rather have the notion of "default" mappings, mappings that are set for source and destination providers and are selected by default when creating a plan with these providers?

makes sense to me 👍

a. it will be the responsibility of a user ( sys admin, or self serve user ) to create this one time "default X to Y mappings"
b. once a "from X to Y default mapping" exist, it will be the default mapping suggested to the user in the fast create instead of using "all" to "pod net" and "all" to "default storage"

@yaacov
Copy link
Member Author

yaacov commented Mar 25, 2024

addressed by #801

@yaacov yaacov closed this as completed Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Categorizes issue or PR as related to a new feature. mappings
Projects
None yet
Development

No branches or pull requests

4 participants