Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Operations] Ensure we accept only limited size of payload from 3rd party systems (Director, OAUth) #177

Open
1 task
tobiscr opened this issue May 23, 2024 · 0 comments
Labels
bv/security Business Value: Security (see ISO 25010)

Comments

@tobiscr
Copy link

tobiscr commented May 23, 2024

Description

To ensure an external system cannot overload the Compass Manager, we have to ensure that we don't accept unusual huge response bodies from remote calls to 3rd party systems (e.g. Director or OAuth).

The HTTP Client should stop the request if the response body is bigger than 2 MB as it's indicating an unusual behaviour of the 3rd party system.

AC:

  • Verify calls to remote systems and adjust all calls to accept only a limited size of the response body (e.g. 2 MB or any other meaningful size). Compass communicagtes usually to three remote systems, like Compass Director, Compass Connector and the OAuth-provider.

Reasons

Prevent outages of Compass Manager in case of 3rd party system misbehaviour.

Attachments

@tobiscr tobiscr added the bv/security Business Value: Security (see ISO 25010) label May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bv/security Business Value: Security (see ISO 25010)
Projects
None yet
Development

No branches or pull requests

1 participant