Remove support for disable-external-name-alias annotation

[strekm]

Description

Istio discontinues support for ENABLE_EXTERNAL_NAME_ALIAS on main branch that will be released with 1.24 release. As a consequence Istio module will discontinue disable-external-name-alias annotation. Remove support for annotation and make sure that ENABLE_EXTERNAL_NAME_ALIAS is set to default value.

Motivation

Remove functionality not supported by Istio

TODOs:

• remove code which reacts to the annotation presence and applies the env var
• adjust tests
• append RN
• remove stale docs

ACs:

• disable-external-name-alias annotation set on Istio CR does not change default value
• disable-external-name-alias annotation is ignored by Istio module
• ENABLE_EXTERNAL_NAME_ALIAS is removed from IstioOperator file
• disable-external-name-alias annotation is removed from documentation
• provide user friendly release notes

PRs:

• Remove support for disable external name alias annotation #1071

DoD:

• Provide unit and integration tests.
• Provide documentation.
• Verify if the solution works for both open-source Kyma and SAP BTP, Kyma runtime.
• If you changed the resource limits, explain why it was needed.
• If the default configuration of Istio Operator has been changed, you performed a manual upgrade test to verify that the change can be rolled out correctly.
• Verify that your contributions don't decrease code coverage. If they do, explain why this is the case.
• Add release notes.

Attachments