-
-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
testcase for broken Header\AbstractAddressList::fromString #44
Comments
toString invocation path:
Originally posted by @glensc at zendframework/zend-mail#146 (comment) |
perhaps the fix is in zend-mime project: if it gets accepted! Originally posted by @glensc at zendframework/zend-mail#146 (comment) |
after zendframework/zend-mime#26 being applied, $headerLine = 'To: "=?iso-8859-1?Q?W=2C_bj=F8rn?=" <user@example.org>';
echo Mail\Header\GenericHeader::fromString($headerLine)->toString(); before:
now:
and // with headerline without comma:
$headerLine = 'To: =?UTF-8?Q?"W=2C=20bj=C3=B8rn"=20<user@example.org>?=';
echo Mail\Header\To::fromString($headerLine)->toString();
Originally posted by @glensc at zendframework/zend-mail#146 (comment) |
@weierophinney closed this in zendframework/zend-mime@73e6d05 15 days ago this is not correct. reopen please. Originally posted by @glensc at zendframework/zend-mail#146 (comment) |
@glensc I think I'm not understanding something. The original string includes an encoded comma ( Why should the comma NOT be encoded when the (I need to understand why your expectation should be the expected behavior, basically.) Originally posted by @weierophinney at zendframework/zend-mail#146 (comment) |
@weierophinney it's combination of these two statements from Pull Description:
i tried to explain the problem in test comments as well: https://github.com/zendframework/zend-mail/pull/146/files if my explanation is not understandable (not sure i catched your question), just see the test code and how it behaves. it's a lot of information and i dealed with this problem more than year ago.... so, this seemed the simplest way to solve the problem. it's not forbidden to zealously encode as zendframework/zend-mime@73e6d05 was accepted in zendframework/zend-mime#26 this just updates unit test data. Originally posted by @glensc at zendframework/zend-mail#146 (comment) |
This repository has been moved to laminas/laminas-mail. If you feel that this patch is still relevant, please re-open against that repository, and reference this issue. To re-open, we suggest the following workflow:
Originally posted by @weierophinney at zendframework/zend-mail#146 (comment) |
Problem:
Lazyload does stringify and load in from string
However, toString does not encode comma
AND To header class does split on comma!
see \Zend\Mail\Header\AbstractAddressList::fromString
this PR shows only the problem.
Originally posted by @glensc at zendframework/zend-mail#146
The text was updated successfully, but these errors were encountered: