Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu view helper: Can't set class on li and a elements #1

Open
weierophinney opened this issue Dec 31, 2019 · 10 comments
Open

Menu view helper: Can't set class on li and a elements #1

weierophinney opened this issue Dec 31, 2019 · 10 comments

Comments

@weierophinney
Copy link
Member

when working with bootsrap4 it is not enough to set class on ul element. Maybe add methods like setULClass for li and a?


Originally posted by @svycka at zendframework/zend-navigation#76

@weierophinney
Copy link
Member Author

You can add the classes to the li element instead of the a element or you can use a partial script. The last option should help you.

At the moment we will not add more methods to the view helper, because we will rework and simplify the whole rendering of the helpers.


Originally posted by @froschdesign at zendframework/zend-navigation#76 (comment)

@weierophinney
Copy link
Member Author

@froschdesign yes I could but look https://getbootstrap.com/docs/4.0/components/navbar/#supported-content

<ul class="navbar-nav mr-auto">
      <li class="nav-item active">
        <a class="nav-link" href="#">Home</a>

all ul, li and a has to have a custom class and if I change from a to li this still not help.
And yes I can use a partial script(that's what I do now), but that's annoying because I have to manage active page acl and everything myself I haven't tested yet other helpers but they may have problems as well


Originally posted by @svycka at zendframework/zend-navigation#76 (comment)

@weierophinney
Copy link
Member Author

@froschdesign when this could happen I guess not any time soon?


Originally posted by @svycka at zendframework/zend-navigation#76 (comment)

@weierophinney
Copy link
Member Author

@svycka
I know the Bootstrap "Navbar" and all the classes.

…I haven't tested yet other helpers but they may have problems as well

Please keep in mind zend-navigation was developed and released before Bootstrap or Foundation had a first release.

…but that's annoying because I have to manage active page acl…

It's very simple.

when this could happen I guess not any time soon?

Why are you so pessimistic? We are already working on it! (zend-expressive support first, then the rework of the view helpers)
In the meantime, I would extend the view helper, then you do not need a partial script.


Originally posted by @froschdesign at zendframework/zend-navigation#76 (comment)

@weierophinney
Copy link
Member Author

I am not pessimistic just know that zend-* has a lot of projects and only a few people to work on them.


Originally posted by @svycka at zendframework/zend-navigation#76 (comment)

@sologub-s
Copy link

Hello. Are there any update on this ? Going through tutorial and stucked in the same trouble - still no ability to set li and a classes, have to use partial template.

@gitAasharAzeem
Copy link

Hello Everyone is There any Update on this ? or a way ? could anyone share an example. it's 2021 still couldn't find any soluton :-(

@froschdesign
Copy link
Member

@Aawshirazeem

…could anyone share an example. it's 2021 still couldn't find any soluton

Use a partial to create a custom HTML output.

@gitAasharAzeem
Copy link

I tried custom Html output, But with Partial I couldn't able to set class to tag. Is there any example that could help.
Thank You

@froschdesign
Copy link
Member

froschdesign commented Jan 27, 2021

@Aawshirazeem

I tried custom Html output, But with Partial I couldn't able to set class to tag.

You can add additional parameters to a partial script. See: https://docs.laminas.dev/laminas-navigation/helpers/menu/#using-additional-parameters-in-partial-view-scripts


Please keep in mind this is not a support forum. For further questions, please use our forums. Add your use case and a code example and I will help you.
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants