Using degrees instead of radians in math.tan()

[jordisanglas]

In file stress.py, found in pydfnworks/pydfnworks/dfnGen/generation, there is the stress_based_apertures function. In line 137:

dilation = min(dilation_tmp, critical_shear_displacement) * m.tan(m.degrees(dilation_angle))

The variable dilation_angle is converted to degrees. However, function m.tan() requires radians. Also, note that the default values for friction_angle and dilation_angle (24.9 and 5) seem to be in degrees. If so, friction_angle should be converted to radians before being used in line 123:

shear_stress_critical = -sigma_mag * m.tan(friction_angle)

[msweeney2796]

Hello,

Thank you for pointing this issue out. You are correct that both instances should be m.tan(m.radians()). We will fix and push update soon.