Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert to not allocating fluid cons vars if fluid is not active? #129

Open
brryan opened this issue Oct 17, 2022 · 1 comment
Open

Revert to not allocating fluid cons vars if fluid is not active? #129

brryan opened this issue Oct 17, 2022 · 1 comment

Comments

@brryan
Copy link
Collaborator

brryan commented Oct 17, 2022

There are some difficulties getting radiation to work right in all cases if the fluid is off when not allocating fluid cons variables, so I changed the code in #104 to always allocate both fluid prim and cons vars. Maybe in the future we want to think a little more carefully and stop allocating fluid cons vars if we don't have fluid fluxes.

@brryan brryan mentioned this issue Oct 17, 2022
17 tasks
@Yurlungur
Copy link
Collaborator

I think it's fine to allocate fluid cons, if we need them, so long as the fluid is frozen and not evolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants