Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug, test only] Cancelling the serial connect browser dialog gives a TypeError #132

Closed
rmoesbergen opened this issue Oct 11, 2024 · 0 comments · Fixed by #134
Closed

[bug, test only] Cancelling the serial connect browser dialog gives a TypeError #132

rmoesbergen opened this issue Oct 11, 2024 · 0 comments · Fixed by #134
Assignees
@sverben
Labels
bug Something isn't working

Comments

@rmoesbergen
Copy link
Member

rmoesbergen commented Oct 11, 2024 •
edited
Loading

When I click on cancel during the browser 'choose a serial port' dialog, I now get a TypeError dialog in testleaphyeasybloqs.com, instead of the "No Robot Selected" dialog (in prod). Probably related to #131
@koen1711 koen1711 added the bug Something isn't working label Oct 11, 2024
@sverben sverben self-assigned this Oct 11, 2024
@sverben sverben linked a pull request Oct 11, 2024 that will close this issue
fix: no robot selected #134
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sverben sverben

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: no robot selected leaphy-robotics/leaphy-webbased-svelte
3 participants
@rmoesbergen @sverben @koen1711