Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failure on client exception #17

Open
PedroPMS opened this issue Aug 17, 2023 · 0 comments
Open

Failure on client exception #17

PedroPMS opened this issue Aug 17, 2023 · 0 comments

Comments

@PedroPMS
Copy link

I'm having a "problem" where requests that return 4xx are thrown a client exception. This library treats any error as failure of the circuit breaker, which forces the non-use of guzzle Exceptions, having to deal with the status code.

I was wondering if it makes sense to handle Guzze's RequestException with the executeCircuitBreakerOnResponse method instead of just throwing the exception and mark as failure.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant