Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video Output bug outside screen #62

Open
soundsnow opened this issue Apr 15, 2023 · 4 comments
Open

Video Output bug outside screen #62

soundsnow opened this issue Apr 15, 2023 · 4 comments

Comments

@soundsnow
Copy link

pce fast and supergrafx cores are ok
only @LibretroAdmin updated this pce core with this bug
screenshot tool: RetroArch
1941 - Counter Attack (Japan)-230415-095610

@ghost
Copy link

ghost commented Aug 18, 2023

Are you using a handheld device like PSP?

That looks a non-power-of-2 pitch bug with the physical hardware.

  • pce_fast = 512 width
  • pce_full = 1365 width (triggering the skew).

We'd have to round up to 2048, but also need someone for testing.

@ghost
Copy link

ghost commented Aug 18, 2023

I remember now. Some hardware are optimized (fixed) for 4-byte framebuffer alignment.

Likely why there's the +3 in the code, but it's not fully done.

EDIT:
Reference:
#3

289a25b
(that's not enough though)

@ghost
Copy link

ghost commented Aug 20, 2023

Tagging #69

@negativeExponent
Copy link
Contributor

negativeExponent commented Oct 10, 2024

max_width should probably set this to the aligned width as well

info.geometry.max_width = MEDNAFEN_CORE_GEOMETRY_MAX_W;

Who are still having this issue?

based on vce.cpp references, each scanline has a max of 2048 pixel, so a max buffer width of 2048 should be fine here and got back to use mdfn provided pitch (DisplayRect->pitch), with expected maximum lines to be 264.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants