Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bounty] MSX Save Support #134

Open
wilhitewarrior opened this issue Feb 18, 2021 · 3 comments
Open

[Bounty] MSX Save Support #134

wilhitewarrior opened this issue Feb 18, 2021 · 3 comments

Comments

@wilhitewarrior
Copy link

wilhitewarrior commented Feb 18, 2021

The BlueMSX core currently lacks support for saving outside of savestates. Because achievement support was added to MSX fairly recently, I'd like to see this issue resolved so I'm opening a bounty for it.

As I understand it, I believe that this is because the MSX saved on a second cartridge slot or something like that? And the core lacks the ability to recognize it? Correct me if I'm wrong on this one, never had a real MSX before. However, I believe the standalone emulator was capable of saving, for this reason I believe it would be possible to add save support to the core.

If this feature could be added I'd be very happy to see it, so thanks in advance to anyone willing to take it on

Bountysource Link

@wilhitewarrior wilhitewarrior changed the title [Feature Request] Save Support [Feature Request] MSX Save Support Feb 18, 2021
@wilhitewarrior wilhitewarrior changed the title [Feature Request] MSX Save Support [Bounty] MSX Save Support Feb 20, 2021
@redwizard42
Copy link

Something like this m3u feature from the commodore core would be extremely helpful: https://docs.libretro.com/library/vice/#extra-m3u-features

@Jamiras
Copy link

Jamiras commented Dec 19, 2022

I believe MSX uses a save disk. RetroAchievements hashes disks to ensure the player is using the correct version of the game. Unfortunately, even if we allow a blank disk for the save disk, if it gets updated by the core, it no longer matches the expected hash and gets rejected as incompatible.

There's two potential solutions for this:

  1. Only write changes to the disks in the saves folder (like SRAM). As long as the original disk remains unmodified, it will be valid.
  2. Use the #SAVEDISK: m3u extension as linked above to generate a virtual blank disk. This way there is no original disk to validate.

@hizzlekizzle
Copy link
Contributor

IIRC, some FDS emus make their saves by generating an IPS patch against the original, clean ROM file. Something like that could work, though it might be a hassle to implement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants