Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type hint should be str #92

Open
drewoldag opened this issue Oct 9, 2024 · 0 comments
Open

Type hint should be str #92

drewoldag opened this issue Oct 9, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@drewoldag
Copy link
Collaborator

I believe that in the function definition for create_resutls_dir, the type hint for postfix should be str.

https://github.com/lincc-frameworks/fibad/blob/main/src/fibad/config_utils.py#L237

Not 100% sure here, but looking at the way it's used, and the existing docstring, makes me think that we don't need to specify Union[Path, str] here.

@drewoldag drewoldag added the bug Something isn't working label Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant