Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gradle tasks missing annotations #561

Open
DPUkyle opened this issue Mar 16, 2021 · 0 comments · May be fixed by #567
Open

Gradle tasks missing annotations #561

DPUkyle opened this issue Mar 16, 2021 · 0 comments · May be fixed by #567
Labels
bug For reporting bugs or issuing bug fixes build Build failures and problems enhancement General enhancement plugin

Comments

@DPUkyle
Copy link
Member

DPUkyle commented Mar 16, 2021

A few of the Gradle tasks are missing annotations on public accessors.

These annotations help Gradle understand when tasks need to be re-executed, and whether they are considered up-to-date or their outputs can be cached. Fixing these annotations should improve build speeds for projects applying the pegasus plugin.

See Table 1. Incremental build property type annotations from the relevant docs here.

From a recent travis log:

> Task :gradle-plugins:validateTaskProperties
Task property validation finished with warnings:
  - Warning: Task type 'com.linkedin.pegasus.gradle.tasks.CheckIdlTask': property 'isEquivalent' is not annotated with an input or output annotation.
  - Warning: Task type 'com.linkedin.pegasus.gradle.tasks.CheckIdlTask': property 'isModelCompatible' is not annotated with an input or output annotation.
  - Warning: Task type 'com.linkedin.pegasus.gradle.tasks.CheckIdlTask': property 'isRestSpecCompatible' is not annotated with an input or output annotation.
  - Warning: Task type 'com.linkedin.pegasus.gradle.tasks.CheckRestModelTask': property 'isEquivalent' is not annotated with an input or output annotation.
  - Warning: Task type 'com.linkedin.pegasus.gradle.tasks.CheckRestModelTask': property 'isModelCompatible' is not annotated with an input or output annotation.
  - Warning: Task type 'com.linkedin.pegasus.gradle.tasks.CheckRestModelTask': property 'isRestSpecCompatible' is not annotated with an input or output annotation.
  - Warning: Task type 'com.linkedin.pegasus.gradle.tasks.CheckRestModelTask': property 'isRestSpecEquivalent' is not annotated with an input or output annotation.
  - Warning: Task type 'com.linkedin.pegasus.gradle.tasks.CheckSnapshotTask': property 'isEquivalent' is not annotated with an input or output annotation.
  - Warning: Task type 'com.linkedin.pegasus.gradle.tasks.CheckSnapshotTask': property 'isModelCompatible' is not annotated with an input or output annotation.
  - Warning: Task type 'com.linkedin.pegasus.gradle.tasks.CheckSnapshotTask': property 'isRestSpecCompatible' is not annotated with an input or output annotation.
  - Warning: Task type 'com.linkedin.pegasus.gradle.tasks.CheckSnapshotTask': property 'isRestSpecEquivalent' is not annotated with an input or output annotation.
  - Warning: Task type 'com.linkedin.pegasus.gradle.tasks.CheckSnapshotTask': property 'previousSnapshotDirectory' is missing a @PathSensitive annotation, defaulting to PathSensitivity.ABSOLUTE.
  - Warning: Task type 'com.linkedin.pegasus.gradle.tasks.GenerateRestClientTask': property '_isRestli1BuildersDeprecated' is not annotated with an input or output annotation.
  - Warning: Task type 'com.linkedin.pegasus.gradle.tasks.GenerateRestClientTask': property 'isRestli2FormatSuppressed' is not annotated with an input or output annotation.
@BrianPin BrianPin added bug For reporting bugs or issuing bug fixes build Build failures and problems enhancement General enhancement plugin labels Mar 17, 2021
DPUkyle added a commit to DPUkyle/rest.li that referenced this issue Mar 23, 2021
@DPUkyle
Bump Gradle wrapper to 6.1
ae86782 
 - This change does not require the consumer to use Gradle 6.1
 - Forthcoming opt-in features to improve metadata publishing will require Gradle 6.1 (linkedin#565)
 - Fixes to linkedin#561 require Gradle 5.4 or higher
@DPUkyle DPUkyle mentioned this issue Mar 23, 2021
Draft
DPUkyle added a commit to DPUkyle/rest.li that referenced this issue Mar 23, 2021
@DPUkyle
Fix linkedin#561 - cleanup task input/output issues
8c69f45 
 - Consumers of the pegasus plugin must use Gradle 5.4+
   - `@ReplacedBy` annotation requires Gradle 5.4+
   - `o.g.w.InputChanges` API requires Gradle 5.4+
DPUkyle added a commit to DPUkyle/rest.li that referenced this issue Mar 23, 2021
@DPUkyle
Fix linkedin#561 - cleanup task input/output issues
ca2f6e1 
 - Consumers of the pegasus plugin must use Gradle 5.4+
   - `@ReplacedBy` annotation requires Gradle 5.4+
   - `o.g.w.InputChanges` API requires Gradle 5.4+
@DPUkyle DPUkyle linked a pull request Mar 23, 2021 that will close this issue
Fix #561 - cleanup task input/output issues #567
Draft
DPUkyle added a commit to DPUkyle/rest.li that referenced this issue Mar 24, 2021
@DPUkyle
Bump Gradle wrapper to 6.1
6db8bc1 
 - This change does not require the consumer to use Gradle 6.1
 - Forthcoming opt-in features to improve metadata publishing will require Gradle 6.1 (linkedin#565)
 - Fixes to linkedin#561 require Gradle 5.4 or higher
DPUkyle added a commit to DPUkyle/rest.li that referenced this issue Mar 24, 2021
@DPUkyle
Fix linkedin#561 - cleanup task input/output issues
6cff6d3 
 - Consumers of the pegasus plugin must use Gradle 5.4+
   - `@ReplacedBy` annotation requires Gradle 5.4+
   - `o.g.w.InputChanges` API requires Gradle 5.4+
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug For reporting bugs or issuing bug fixes build Build failures and problems enhancement General enhancement plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #561 - cleanup task input/output issues DPUkyle/rest.li
2 participants
@BrianPin @DPUkyle