Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A zero image is currently parsed as a BIOS region with a padding. Is that an intended behavior? #325

Open
xaionaro opened this issue Nov 27, 2020 · 1 comment

Comments

@xaionaro
Copy link
Member

xaionaro commented Nov 27, 2020

Currently if I call uefi.Parse on an image with just a bunch of zeros inside, it will be parsed as a BIOS region with a padding.

While I use uefi.Parse to also verify if a received file is really an UEFI image (not something else). And a zero-file is a quite typical case. For example I faced this problem when another program (which extracts an UEFI image) just works wrong (and extracts a zero-image instead).

So the question is: do we consider parsing a bunch of zeros as a valid BIOS region a correct behavior (for fiano) or not?

@GanShun
Copy link
Member

GanShun commented Jul 19, 2021

Currently yes, but we should rethink this when we add better support for AMD and other file systems like CBFS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants