Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Please allow user to set their values like maximum timeout, php memory limit, php upload limit #462

Closed
1 task done
iamniki01 opened this issue Jul 30, 2024 · 4 comments

Comments

@iamniki01
Copy link

Is this a new feature request?

  • I have searched the existing issues

Wanted change

As mentioned in the subject, please allow user to set php related values by giving environment variables

Reason for change

Indeed, this is important, the default value is not sufficient if we used need to use it for larger file system.

Proposed code change

It would be easy to set environment variables in dockerfile, then user can override those default environment variables value with their values.

P.S: If you assign me, I am happy to contribute this issue.

Copy link

Thanks for opening your first issue here! Be sure to follow the relevant issue templates, or risk having this issue marked as invalid.

@Roxedus
Copy link
Member

Roxedus commented Jul 30, 2024

You can already change these, by changing the files in /config/php.
We will not make these configurable with variables, as we try to keep those to a minimum.

@Roxedus Roxedus closed this as completed Jul 30, 2024
@iamniki01
Copy link
Author

iamniki01 commented Jul 30, 2024

if that is the case, its an empty ini file, the initialized php.ini file is in /etc/php82/php.ini. If i add my changes in /config/php/php-local.ini, does it overwrite or override the default values in /etc/php82/php.ini with user values. is it possible to change in the running container?

@Roxedus
Copy link
Member

Roxedus commented Jul 30, 2024

It overrides. I believe php needs a restart to pick up the changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

2 participants