Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to update the road centre line of an existing Proposed address. #230

Open
SPlanzer opened this issue Mar 17, 2019 · 2 comments
Open
Assignees

Comments

@SPlanzer
Copy link

originally opened as part of #229 and the below is copied over.

Issue 2 - Unable to update the road centre line of an existing Proposed address.
Steps to reproduce the error message is as follows:

  1. Search for an existing proposed address.
  2. Click on the Update AIMS Feature button.
  3. Click on the button used to select a new road centre line.
  4. Select a different road centre line and submit.

image

This causes issues because if a road centre line needs to be changed, the address has be retired and then re-entered. The user has to attach the address to the correct centre line and make it proposed again.

@SPlanzer SPlanzer changed the title Can not edit the road centreline if a proposed address is associated Unable to update the road centre line of an existing Proposed address. Mar 17, 2019
@SPlanzer SPlanzer reopened this Mar 17, 2019
@SPlanzer SPlanzer self-assigned this Mar 17, 2019
@SPlanzer
Copy link
Author

The UI had a check put in place to stop addresses being updated to proposed (see #213). Its need at the UI level is questionable.

Triage-ing this issue will begin with removing this check and performing this action against the API to confirm the API allows this action. If so, removing the UI check should be considered

@SPlanzer
Copy link
Author

I have built a test environment and confirmed the UI is blocking this action that the API will allow.

The below code can be safely removed from the UI to allow AIMS users to update proposed address properties.

# An address can not got from <x> to proposed
elif form.ulifeCycle.currentText() == 'Proposed':
UiUtility.raiseErrorMesg(iface, 'A Feature may not be updated to "Proposed"')
return False

This will not have any adverse effects as the API checks for addresses being changed from current to proposed, a situation that may lead to data corruption (see #229)

@MarksNgahi if you would like this improvement made to allow the updating of proposed address properties, please request this work via @TrentGulliver as he will have a better understanding as to how this piece of work would fit into the addressing programme.

This would involve:

  • Removing the above check in the UI
  • A release being created and pushed to the LINZ plugin server
  • The addressing team performing regression testing

Note #213 is related to this.

@SPlanzer SPlanzer removed their assignment Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants