Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename preevy down to preevy rm #164

Open
royra opened this issue Aug 7, 2023 · 3 comments
Open

Rename preevy down to preevy rm #164

royra opened this issue Aug 7, 2023 · 3 comments

Comments

@royra
Copy link
Collaborator

royra commented Aug 7, 2023

Per feedback from @Pradumnasaraf , preevy down might seem to stop the services and keep the machine.

For backwards-compat, keep down as an alias

@royra
Copy link
Collaborator Author

royra commented Aug 8, 2023

Documenting an internal discussion:

  • If we have an up command, it makes sense that the opposite would be down, just like Docker Compose:
    • Docker Compose's down command stops and removes the containers - this is equivalent to Preevy's down command
    • Docker Compose's rm command removes stopped containers (and ignores running containers) - the suggested rm is not equivalent.
  • Maybe we can alias down to rm, or have a dummy rm command which just outputs did you mean "down"?

@Pradumnasaraf
Copy link
Contributor

Ah, this makes sense.

Maybe we can alias down to rm, or have a dummy rm command which just outputs did you mean "down"?

Like this idea.

@royra royra added the need spec label Aug 8, 2023
@Sumit21kumar
Copy link

i am beginner in this filed but i can rename it.
so, only tell me, should i rename all the 'preevy down' to 'preevy rm'?

Sumit21kumar pushed a commit to Sumit21kumar/preevy that referenced this issue Aug 18, 2023
@royra royra mentioned this issue Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants