Skip to content
This repository has been archived by the owner on Mar 7, 2018. It is now read-only.

Notification feedback #14

Open
2 of 3 tasks
lloeki opened this issue Oct 31, 2015 · 11 comments
Open
2 of 3 tasks

Notification feedback #14

lloeki opened this issue Oct 31, 2015 · 11 comments

Comments

@lloeki
Copy link
Owner

lloeki commented Oct 31, 2015

  • Badge on dock or tray icon
  • Bounce dock icon
  • Settings (because it could get obnoxious)
@lloeki
Copy link
Owner Author

lloeki commented Oct 31, 2015

  • Is there anything native like badge icons on Windows?
  • What are the idiomatic ways on Linux DEs?

@Juburin
Copy link

Juburin commented Nov 3, 2015

For notifications on Windows maybe setOverlayIcon could be used https://github.com/atom/electron/blob/master/docs/api/browser-window.md#winsetoverlayiconoverlay-description-windows-7. Also on Windows the webview notifications aren't working, but I don't know if this is an electron issue.

@lloeki
Copy link
Owner Author

lloeki commented Nov 3, 2015

I think that's a regression, notifications did work with an older build on Windows.

setOverlayIconmight do the trick. Any example of apps that use this feature? Screenshots welcome.

@Juburin
Copy link

Juburin commented Nov 3, 2015

I can't give an example, but I found a similar question (with screenshot): electron/electron#3148

@lloeki
Copy link
Owner Author

lloeki commented Nov 3, 2015

Nevermind, it was a false positive, it never worked on Windows. See electron/electron#262

@johnthedebs
Copy link

Just noticed that you linked to an issue I opened on the Electron repo. Here's a gist of the solution I ended up with to provide badges across OS X and Windows if you're curious: https://gist.github.com/johnthedebs/c22a04fcd08e598e69b8

@daemongh
Copy link
Contributor

daemongh commented Nov 3, 2015

Neat, I'll look into adding that into the code I have for the badges.

@daemongh
Copy link
Contributor

daemongh commented Nov 4, 2015

That worked great, I've added it in PR #18.

Screenshot:
windows-badges

@lloeki
Copy link
Owner Author

lloeki commented Nov 4, 2015

Thanks for the screenshot, this looks nice.

@lloeki
Copy link
Owner Author

lloeki commented Nov 5, 2015

PR #18 merged, we now have Windows and OS X covered. Linux remains.

@enahum
Copy link

enahum commented Nov 10, 2015

@lloeki have you tried to click on the notification when the app in minimised on OSX? I found out that the app changes the views inside mattermost but the app itself doesn't get restored as the browser does.

Any thoughts?

geekytime pushed a commit that referenced this issue Dec 30, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants