Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External IP address as optional argument #26

Open
Thomatn opened this issue Jan 29, 2018 · 2 comments
Open

External IP address as optional argument #26

Thomatn opened this issue Jan 29, 2018 · 2 comments

Comments

@Thomatn
Copy link

Thomatn commented Jan 29, 2018

I'd like to have this option since I'm using multiple network interfaces on the same device (resulting in multiple external ip addresses). I'd be nice to add the external IP address as an optional argument if you'd like to set it manually.

Thanks in advance!

@lmammino
Copy link
Owner

Sounds like a good idea.

At a first thought, I would implement this by adding a command line option called --force-ip (followed by the actual ip), and when this option is set, then the ip is not fetched remotely but it's taken from the input.

I won't have much time in the short term to implement this, so feel more the welcome to propose a PR with the needed changes if you are in a rush for this feature.

@pjdsully
Copy link

pjdsully commented Mar 7, 2018

This is one I'd like to see done, too, for a completely different use case. I'll take it on, if nobody has picked it up yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants