Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

permissions.php #13

Open
remiego opened this issue Jul 18, 2014 · 6 comments
Open

permissions.php #13

remiego opened this issue Jul 18, 2014 · 6 comments

Comments

@remiego
Copy link

remiego commented Jul 18, 2014

The permissions.php file returns the same Json regardless of 'id' parameter passed. After adding an additional group and checking the post param, the json response is identical. Will post an update if I find the reason for this. Suspect the users.php to have a similar issue as this returns the same json regardless of "group" parameter when in the Edit Group area.

@remiego
Copy link
Author

remiego commented Jul 18, 2014

Resolved by changing:
$groupId = isset($_REQUEST['group'])

Which is assigning the result of isset rather than the value of the POST value.

if (isset($_REQUEST['group'])) {
$groupId = $_REQUEST['group'];
}

@loiane
Copy link
Owner

loiane commented Jul 18, 2014

Thx! Pl feel free to make pull requests to the book as well. I'll fix the issues found.
Btw, I'm upgrading the project to extjs 5, anything you would like to see in the project as well?

@remiego
Copy link
Author

remiego commented Jul 18, 2014

Well, you provide the most complete end-to-end examples on how to use Extjs already, I'm not interested in touch but imagine others would be. I'm personally interested in creating mixed web/app sites so a non viewport based solution would be great but I appreciate that you are trying to show all of the aspects of Ext and appeal to as broad an audience as possible.

Looking forward to your new book, I'll definitely be buying it. Just for your reference, I actually found your book via looking at some of your php samples on Github, I had previously bought books by Jay Garcia and Shea Fredericks/Steve 'Cutter' Blades, although Jay is a successful author, blogger, video creator and revered member of the community, I personally find your work to be more educative. Keep up the good work!

@ZSimon
Copy link

ZSimon commented Jul 28, 2014

Loiane,
it would be nice to have router in the project, for history and links.
It is usually the requirement of every application.

Otherwise your project is the best example I have ever found and i can't wait to see it in ext 5.

@sahandsepanta
Copy link

I'm looking forward to ExtJs 5 as well, I imagine two way data-binding will make some job much easier. kodoos Loiane.

@sahandsepanta
Copy link

Hi Loiane,
I would love to review the book. The good thing about me is that I've to
finish a project with Extjs and django in 2 months and your book will be
extremely helpful and I can comment on the book while reading it. I'm
working in an NGO who help users circumvent censorship(https://asl19.org/en).
I have built https://khoondi.com and http://meidoon.com/watch. We're based
in Canada and we respect copyright.

Cheers,
Sahand

On Wed, Oct 8, 2014 at 9:29 PM, Loiane Groner notifications@github.com
wrote:

Hi all, would you like reviewing the new version of the book? Your input
would be great - and you get a copy of the book for free as well!
If you are interested, please send me your email (me@loiane.com) so I can
send it to Packt to get in contact with you. Please let me know this week!


Reply to this email directly or view it on GitHub
#13 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants