Replies: 1 comment
-
Hi @gregolsen, I took the freedom of converting your issue into a discussion 👍! The short answer is that Applications have different ways of providing basic authentication, but the recommended one is described on this documentation page (depending on the faraday version you're using). If you follow that doc, your basic auth should use the Appreciate this is probably not what you were hoping for, but in this case, it should be up to the |
Beta Was this translation helpful? Give feedback.
-
This is more of a question at this point.
As part of fixing a credentials leak in Open Telemetry Ruby instrumentation we noticed that
run_request
doesn't remove credentials from the URL as, for example, this code does https://github.com/lostisland/faraday/blob/main/lib/faraday/connection.rb#L366Is that a desired behavior or would it be better to remove basic authentication credentials from the URL in
run_request
too?Beta Was this translation helpful? Give feedback.
All reactions