Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Operation callbacks are missing the conditional arguments #1066

Open
jwoertink opened this issue Sep 25, 2024 · 0 comments
Open

Operation callbacks are missing the conditional arguments #1066

jwoertink opened this issue Sep 25, 2024 · 0 comments
Labels
hacktoberfest Valid Issue for Hacktoberfest

Comments

@jwoertink
Copy link
Member

https://github.com/luckyframework/avram/blob/bb63db88513b05e80030a4c61c9ef48b0ea12dbe/src/avram/callbacks.cr#L97C9-L97C19

With SaveOperation and DeleteOperation you can do before_save :do_thing, if: :valid?, but this doesn't work for before_run or after_run
@jwoertink jwoertink added the hacktoberfest Valid Issue for Hacktoberfest label Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hacktoberfest Valid Issue for Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jwoertink