Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

size attribute requires string parsing. #3

Open
rwe opened this issue Jan 19, 2015 · 1 comment
Open

size attribute requires string parsing. #3

rwe opened this issue Jan 19, 2015 · 1 comment

Comments

@rwe
Copy link

rwe commented Jan 19, 2015

The company size attribute (size) is currently specified to have a string "10-50". In order to get minimum and maximum company size, that string must be split and parsed which seems unreasonable for a machine-readable spec.

Suggest something like:

"companySize": {
    "min": 10,
    "max": 50,
}

Or possible "from" and "to", if it should be consistent with other attributes.

@lukasz-madon
Copy link
Owner

I was thinking about it. You don't really need to know exact number and it changes a lot. Ideally, you want is an enum. I'll look into json schema enums.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants