Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected container order #374

Open
hbugdoll opened this issue Apr 14, 2022 · 4 comments
Open

Unexpected container order #374

hbugdoll opened this issue Apr 14, 2022 · 4 comments
Milestone

Comments

@hbugdoll
Copy link
Member

What steps will reproduce the problem?

Add multiple containers in the CMS.

What is the expected result?

Containers are sorted like in CMS Settings > Containers and thus by ID.

What do you get instead?

Containers are sorted by name in alphabetical order.

Additional infos

Q A
LUYA Version current

@nadar If you agree I can provide a PR.

@nadar
Copy link
Member

nadar commented Apr 18, 2022

In an upcoming release we could add a migration with a sorting field. Maybe we could also use the alias to sort as they are not visible in the UI. So things like 0default 1abc would be possible? What do you think?

@nadar
Copy link
Member

nadar commented Apr 18, 2022

@rolandschaub recommendations?

@hbugdoll
Copy link
Member Author

In an upcoming release we could add a migration with a sorting field. Maybe we could also use the alias to sort as they are not visible in the UI. So things like 0default 1abc would be possible? What do you think?

Using the alias may be a workaround (but we heavily use "fixed" container aliases).
A new sorting ID would be the preferred way and consistent to menu item's sort_index.

@nadar nadar added this to the 5.0 milestone Apr 26, 2022
@nadar
Copy link
Member

nadar commented Apr 26, 2022

A new migration would require us to release a new major version (5.0). So i will assign this milestone 👍

@nadar nadar modified the milestones: 5.0, 6.0 Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants