Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

impl IntoUstr for &PathBuf #16

Open
ColonelThirtyTwo opened this issue Mar 20, 2023 · 1 comment
Open

impl IntoUstr for &PathBuf #16

ColonelThirtyTwo opened this issue Mar 20, 2023 · 1 comment

Comments

@ColonelThirtyTwo
Copy link

IntoUstr is implemented for PathBuf and &'a Path, but not for &'a PathBuf. This requires users to call pathbuf.as_path(), which is mildly inconvenient. I suggest implementing IntoUstr for &'a PathBuf and have it do as_path internally for convenience.
@mahkoh
Copy link
Owner

mahkoh commented Apr 14, 2023

Please create a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ColonelThirtyTwo @mahkoh