Question about IP discovery

[suchmememanyskill]

Hello,

I've recently migrated from the local-tuya to the tuya-local project.
After integrating the devices, all stats/functionalities show up as expected (great project!).

Although, after a tuya device (in this instance, some kind of smart plug) loses power, the integration does not pick up on it again.
local-tuya was able to pick up devices after a power cycle.

When i looked into why the ip of the device changed, to my horror i found its mac address is randomised on each boot.
So it makes sense why the ip changes on each boot.

How does tuya-local deal with these ip changes?
When i run a tinytuya scan, the devices do appear there, but the integration does not seem to recover from a lost ip.

(I can provide logs and such if needed, but this is more so a question of how ip discovery works. I don't know if this is expected behaviour or not)

(Also weirdly, sometimes the device changes its ip back to what it was before, but not always)

[yarafie]

Just a suggestion. Why Don't you set a static IP to the device. I've done this with all my Wifi Smart devices to guarantee no changes

[suchmememanyskill]

This is (usually) done based on mac address. If the mac address randomizes i can't lock the ip of the device.

[make-all]

IP discovery will not work if you still have localtuya installed, as the broadcast port is fixed so there can only be one listener on each IP address (the HA IP address here). To use IP discovery, you can enter "Auto" for the IP address, but that has a downside of making recovery take longer, and possibly failing due to localtuya presence. Static IP assignment in your router is a much more robust solution.

Setting the protocol version explicitly will also help with recovery a lot, as it can take 5 minutes of timeouts and retries to cycle through just one attempt at reconnecting using all the protocols (and if the address is set to Auto, there are further delays as the library does IP discovery on every attempt).

[make-all]

What version of tuya-local are you using?

[suchmememanyskill]

When i performed these tests above, HA Core 2024.8.1, Tuya-local 2024.7.1.

Just updated to HA Core 2024.8.3, Tuya-local 2024.8.0 and i can reproduce the same issue.

I do get a stack trace now, if that's any help to you:

2024-08-27 13:14:40.331 WARNING (MainThread) [homeassistant.util.loop] Detected blocking call to sleep with args (0.1,) inside the event loop by custom integration 'tuya_local' at custom_components/tuya_local/device.py, line 78: self._api = tinytuya.Device(dev_id, address, local_key) (offender: /usr/local/lib/python3.12/site-packages/tinytuya/scanner.py, line 1453: time.sleep( need_sleep )), please create a bug report at https://github.com/make-all/tuya-local/issues
For developers, please see https://developers.home-assistant.io/docs/asyncio_blocking_operations/#sleep
Traceback (most recent call last):
  File "<frozen runpy>", line 198, in _run_module_as_main
  File "<frozen runpy>", line 88, in _run_code
  File "/usr/src/homeassistant/homeassistant/__main__.py", line 223, in <module>
    sys.exit(main())
  File "/usr/src/homeassistant/homeassistant/__main__.py", line 209, in main
    exit_code = runner.run(runtime_conf)
  File "/usr/src/homeassistant/homeassistant/runner.py", line 190, in run
    return loop.run_until_complete(setup_and_run_hass(runtime_config))
  File "/usr/local/lib/python3.12/asyncio/base_events.py", line 674, in run_until_complete
    self.run_forever()
  File "/usr/local/lib/python3.12/asyncio/base_events.py", line 641, in run_forever
    self._run_once()
  File "/usr/local/lib/python3.12/asyncio/base_events.py", line 1990, in _run_once
    handle._run()
  File "/usr/local/lib/python3.12/asyncio/events.py", line 88, in _run
    self._context.run(self._callback, *self._args)
  File "/usr/local/lib/python3.12/site-packages/aiohttp/web_protocol.py", line 462, in _handle_request
    resp = await request_handler(request)
  File "/usr/local/lib/python3.12/site-packages/aiohttp/web_app.py", line 537, in _handle
    resp = await handler(request)
  File "/usr/local/lib/python3.12/site-packages/aiohttp/web_middlewares.py", line 114, in impl
    return await handler(request)
  File "/usr/src/homeassistant/homeassistant/components/http/security_filter.py", line 92, in security_filter_middleware
    return await handler(request)
  File "/usr/src/homeassistant/homeassistant/components/http/forwarded.py", line 83, in forwarded_middleware
    return await handler(request)
  File "/usr/src/homeassistant/homeassistant/components/http/request_context.py", line 26, in request_context_middleware
    return await handler(request)
  File "/usr/src/homeassistant/homeassistant/components/http/ban.py", line 85, in ban_middleware
    return await handler(request)
  File "/usr/src/homeassistant/homeassistant/components/http/auth.py", line 242, in auth_middleware
    return await handler(request)
  File "/usr/src/homeassistant/homeassistant/components/http/headers.py", line 32, in headers_middleware
    response = await handler(request)
  File "/usr/src/homeassistant/homeassistant/helpers/http.py", line 73, in handle
    result = await handler(request, **request.match_info)
  File "/usr/src/homeassistant/homeassistant/components/http/decorators.py", line 81, in with_admin
    return await func(self, request, *args, **kwargs)
  File "/usr/src/homeassistant/homeassistant/components/config/config_entries.py", line 285, in post
    return await super().post(request, flow_id)
  File "/usr/src/homeassistant/homeassistant/components/http/data_validator.py", line 74, in wrapper
    return await method(view, request, data, *args, **kwargs)
  File "/usr/src/homeassistant/homeassistant/helpers/data_entry_flow.py", line 122, in post
    result = await self._flow_mgr.async_configure(flow_id, data)
  File "/usr/src/homeassistant/homeassistant/data_entry_flow.py", line 366, in async_configure
    result = await self._async_configure(flow_id, user_input)
  File "/usr/src/homeassistant/homeassistant/data_entry_flow.py", line 413, in _async_configure
    result = await self._async_handle_step(
  File "/usr/src/homeassistant/homeassistant/data_entry_flow.py", line 516, in _async_handle_step
    result: _FlowResultT = await getattr(flow, method)(user_input)
  File "/config/custom_components/tuya_local/config_flow.py", line 560, in async_step_user
    device = await async_test_connection(config, self.hass)
  File "/config/custom_components/tuya_local/config_flow.py", line 608, in async_test_connection
    device = TuyaLocalDevice(
  File "/config/custom_components/tuya_local/device.py", line 78, in __init__
    self._api = tinytuya.Device(dev_id, address, local_key)

[suchmememanyskill]

@make-all

diff --git a/custom_components/tuya_local/config_flow.py b/custom_components/tuya_local/config_flow.py
index 3cf400e5..e2e9951b 100644
--- a/custom_components/tuya_local/config_flow.py
+++ b/custom_components/tuya_local/config_flow.py
@@ -605,6 +605,21 @@ async def async_test_connection(config: dict, hass: HomeAssistant):

     try:
         subdevice_id = config.get(CONF_DEVICE_CID)
+
+        if config[CONF_HOST] == "Auto":
+            try:
+                local_device = await hass.async_add_executor_job(
+                    scan_for_device, config[CONF_DEVICE_ID]
+                )
+
+                if "ip" not in local_device or local_device["ip"] == None:
+                    raise Exception("Ip not found in local_device")
+
+                config[CONF_HOST] = local_device["ip"]
+                _LOGGER.info("Found auto device ip: %s", config[CONF_HOST])
+            except Exception as e:
+                _LOGGER.error("Retrieving auto ip failed with %s %s", type(e), e)
+
         device = TuyaLocalDevice(
             "Test",
             config[CONF_DEVICE_ID],

This is a bit of a hack but it at least allows me to set an 'Auto' address. Feel free to refine this (although, probably want to address the root issue of creating a tinytuya object being able to stall)

[make-all]

I have a similar change in testing now, but it causes two unit test failures, so I need to investigate whether the unit test needs updating or the change has side effects before committing.

[suchmememanyskill]

Commit works as expected, thank you so much!