Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI to use flake and / or black #425

Open
mnlevy1981 opened this issue May 10, 2023 · 1 comment
Open

Update CI to use flake and / or black #425

mnlevy1981 opened this issue May 10, 2023 · 1 comment

Comments

@mnlevy1981
Copy link
Collaborator

A recent code review for #423 highlighted an inconsistency in the Python code; we sometimes use ' and other times use ". We need to run our code through some automated formatters as part of every PR.

In feisty we are using pre-commit to automate the format-checking, and then one of the Github actions runs the pre-commit packages on a github VM to verify nothing needs to be changed. I think this is a reasonable workflow, and suggest we adopt something similar here.

@mnlevy1981
Copy link
Collaborator Author

Another related issue is that there is still a lot of python2 code in our repository -- e.g. we don't need to convert strings to u-strings, since that's the default type for python3. And it would be nice to have pylint check more of our python files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant