-
Notifications
You must be signed in to change notification settings - Fork 25
Processes to finalize
Michael Levy edited this page Mar 24, 2016
·
10 revisions
- What testing should be done prior to making a pull request?
- Is any additional testing needed before accepting pull request?
- How do we make sure enough eyes see the code before accepting?
- NAG doesn't allow lines to exceed 132 characters - there is a branch on mnlevy1981/MARBL (with a pull request submitted to bring it back to master) that has a script that checks for lines exceeding this maximum, maybe we should add it as a commit hook? Or at least provide it so users can run the check themselves?
- CESM supports five compilers: intel, gnu, pgi, NAG, and cray. I don't know if ACME supports any additional compilers (IBM?), but we need to verify that code builds on all those platforms (spoiler alert: pgi doesn't work). For developers that don't have access to all those compilers, how do we enforce this?
- What should the interface between GCM and MARBL look like? (Or maybe interfaces?)
- How will the interface(s) be documented / shared with the public?
- Do we want a public-facing repository to push releases to? I'm thinking of something similar to the MPAS set-up, where code stays on the private development repository until it has been written up and submitted for peer review.