Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the update_interval configurable #54

Open
3 tasks done
pegasus75 opened this issue Nov 28, 2023 · 5 comments · Fixed by #107
Open
3 tasks done

Make the update_interval configurable #54

pegasus75 opened this issue Nov 28, 2023 · 5 comments · Fixed by #107
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@pegasus75
Copy link

Checklist

  • I have filled out the template to the best of my ability.
  • This only contains 1 feature request (if you have multiple feature requests, open one feature request for each feature request).
  • This issue is not a duplicate feature request of previous feature requests.

Is your feature request related to a problem? Please describe.

The current update_interval is static and is 10. This causes frequent data pulls and potential more data points that someone might need/want

Describe the solution you'd like

I would like this variable to be configurable in the Integration

Describe alternatives you've considered

Hardcoded change in coordinator.py

Additional context

@marcoboers marcoboers added the enhancement New feature or request label Dec 1, 2023
@marcoboers
Copy link
Owner

To be honest, I'm not sure if this is easy to do. There used to be a scan_interval but that was dropped by HA quite some time ago. Please let me know if you know of any integration that allows modifying the interval. I might be able to use it as inspiration.

@marcoboers marcoboers added the help wanted Extra attention is needed label Dec 9, 2023
@WebSpider
Copy link

The route I've seen a few integrations take to support this, is disable updating automatically, and add supporting update via a service call. Then the end-user gets to implement an automation to decide when to update.

@wouzzie
Copy link

wouzzie commented Aug 18, 2024

Hi! Just stumbled upon this, but in my HA I use the Plugwise integration to control my thermostat. That integration (in the beta channel) supports setting the update interval manually from the configuration options. Might be a source of inspiration! https://github.com/plugwise/plugwise-beta

@patrickvorgers
Copy link
Contributor

@marcoboers

Looking at the code you are already using "update_interval" in the Coordinator. When I change the timedelta into 20 seconds the data is refreshed every 20 seconds. Am I missing something?

        super().__init__(
            hass=hass,
            logger=LOGGER,
            name=DOMAIN,
            update_interval=timedelta(seconds=20),
        )

patrickvorgers added a commit to patrickvorgers/home-assistant-quatt that referenced this issue Aug 28, 2024
patrickvorgers added a commit to patrickvorgers/home-assistant-quatt that referenced this issue Aug 28, 2024
patrickvorgers added a commit to patrickvorgers/home-assistant-quatt that referenced this issue Aug 28, 2024
patrickvorgers added a commit to patrickvorgers/home-assistant-quatt that referenced this issue Aug 28, 2024
…pdate-interval

Revert "Make the update_interval configurable marcoboers#54"
@marcoboers marcoboers linked a pull request Sep 13, 2024 that will close this issue
@marcoboers
Copy link
Owner

I tagged a beta release!
Make sure to go to settings -> devices -> HACS -> Quatt and turn on "Pre-release" toggle to be able to download the beta.
https://github.com/marcoboers/home-assistant-quatt/releases/tag/0.6.0b1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants