Migrate worker code in separate Components instead of Bundles

[gplanchat]

Hello,

Marello's source code is separated in several Symfony bundles, which is useful if you use Marello's application as a whole, but can create some issues when you need to integrate it with other systems (e-commerce, crm, pim, etc...). I suppose some simple integrations will come with OroCRM, Akeneo and other Symfony applications, but what about incompatible systems?

A move I think was good in Akeneo is moving worker code into components, adding several interfaces which enabled code reuse and easy data backend switching. Bundles then became glue code and config between Symfony and the components. In the case of Marello it could be for different complexity of warehouse management, different tax calculation engines, etc.

Do Marello has a plan to make such move in the near future? Would PR in this way would be accepted?

[24198]

Hi @gplanchat,

Thank you for your question! I've read your question and put some thought in this. There are, as you mentioned, some complexities in order to achieve something like this.

As you mentioned, some will probably not use the complete suite of Marello and in those cases they want to have separate bundles/components and use them as stand alone parts. Even though it's not possible for us now (since we are focusing on getting the stuff done ;)), I think that some parts can be extracted and be moved into components.

As for now, we don't have any plans to do this in the near future, but we might consider doing so if there are enough cases and or requests to make this happen. A PR would be awesome and if this is something you are able to pull off we would be sure to consider it to accept it and go from there :)

Kind Regards,

Jaimy Casteleijn

[gplanchat]

Thank you Jaimy, I've started some work on https://github.com/gplanchat/marello/commits/enhancement/enforcing-contracts

[gplanchat]

Referenced in #5

[24198]

Hi @gplanchat,

Thank you for the PR, we'll be reviewing and testing the changes shortly. So far it looks great, thank you. We're also made a lot of changes in the past few months so we have to see what needs to be done to merge all of it. I'll be in contact soon :).

Kind Regards,

Jaimy Casteleijn

[gplanchat]

@24198 could you push the changes that has been made since march on your side ? It would be easiest to merge PR if I had access to the code.

Thanks a lot

[24198]

Hi @gplanchat

We will push it as soon as possible. We also want to make sure that all the things in the PR are OK and tests are still running without the modifications of last months. I'll probably start working on it tomorrow and get back to you on the PR (and the modifications of last month).

Kind Regards,

Jaimy Casteleijn